Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move predicates files to legacy #3270

Merged
merged 6 commits into from
Nov 1, 2019
Merged

Move predicates files to legacy #3270

merged 6 commits into from
Nov 1, 2019

Conversation

cwharris
Copy link
Contributor

No description provided.

@cwharris cwharris added the 2 - In Progress Currently a work in progress label Oct 31, 2019
@cwharris cwharris requested review from a team as code owners October 31, 2019 21:46
@cwharris cwharris requested a review from a team October 31, 2019 21:46
@cwharris cwharris requested a review from a team as a code owner October 31, 2019 21:46
@jrhemstad
Copy link
Contributor

Make sure #3265 is merged before this PR.

@cwharris cwharris added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Oct 31, 2019
@codecov
Copy link

codecov bot commented Oct 31, 2019 •
edited
Loading

Codecov Report

Merging #3270 into branch-0.11 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           branch-0.11    #3270   +/-   ##
============================================
  Coverage        87.13%   87.13%           
============================================
  Files               49       49           
  Lines             9269     9269           
============================================
  Hits              8077     8077           
  Misses            1192     1192

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cce809...397e65f. Read the comment docs.

harrism
harrism requested changes Nov 1, 2019
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update include path in conda/recipes/libcudf/meta.yaml

Otherwise I think it's good.

@cwharris
Copy link
Contributor Author

cwharris commented Nov 1, 2019

rerun tests

@cwharris
Copy link
Contributor Author

cwharris commented Nov 1, 2019

@harrism Is this right?

https://github.com/rapidsai/cudf/pull/3270/files#diff-e7594bfb6059a18b2c92a59da9b20b75L74

@harrism harrism merged commit 6bca9f6 into rapidsai:branch-0.11 Nov 1, 2019
@cwharris
Copy link
Contributor Author

cwharris commented Nov 1, 2019

#2941

@cwharris cwharris deleted the cudf-2941-port-legacy branch December 21, 2019 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cwharris @jrhemstad @harrism