Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Series/DataFrame notnull #2844

Merged
merged 3 commits into from
Sep 19, 2019
Merged

[REVIEW] Series/DataFrame notnull #2844

merged 3 commits into from
Sep 19, 2019

Conversation

beckernick
Copy link
Member

Summary of Changes

Closes #2840

@beckernick beckernick added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. labels Sep 19, 2019
@beckernick beckernick requested a review from a team as a code owner September 19, 2019 14:52
@beckernick beckernick self-assigned this Sep 19, 2019
@codecov
Copy link

codecov bot commented Sep 19, 2019

Codecov Report

Merging #2844 into branch-0.10 will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.10    #2844      +/-   ##
===============================================
+ Coverage         86.5%   86.52%   +0.01%     
===============================================
  Files               48       48              
  Lines             8931     8942      +11     
===============================================
+ Hits              7726     7737      +11     
  Misses            1205     1205
Impacted Files Coverage Δ
python/cudf/cudf/core/dataframe.py 93.61% <100%> (+0.04%) ⬆️
python/cudf/cudf/core/series.py 93.34% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d164d44...a0501f0. Read the comment docs.

CHANGELOG.md Outdated Show resolved Hide resolved
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Sep 19, 2019
@kkraus14 kkraus14 merged commit 7845808 into rapidsai:branch-0.10 Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Implement notnull, an alias for notna, for Series / DataFrame
2 participants