Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix groupby.len with null values in cudf.polars #17671

Merged
merged 2 commits into from
Jan 3, 2025
+13 −3
Merged

Fix groupby.len with null values in cudf.polars #17671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d78fc17
Fix groupby.len with null values in cudf.polars
mroeschke Jan 2, 2025
ad9b125
Merge branch 'branch-25.02' into bug/polars/gb_count
mroeschke Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions python/cudf_polars/cudf_polars/dsl/expressions/aggregation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# SPDX-FileCopyrightText: Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES.
# SPDX-FileCopyrightText: Copyright (c) 2024-2025, NVIDIA CORPORATION & AFFILIATES.
# SPDX-License-Identifier: Apache-2.0
# TODO: remove need for this
# ruff: noqa: D101
Expand Down Expand Up @@ -69,7 +69,11 @@ def __init__(
# TODO: handle nans
req = plc.aggregation.variance(ddof=options)
elif name == "count":
req = plc.aggregation.count(null_handling=plc.types.NullPolicy.EXCLUDE)
req = plc.aggregation.count(
null_handling=plc.types.NullPolicy.EXCLUDE
if not options
else plc.types.NullPolicy.INCLUDE
)
elif name == "quantile":
_, quantile = self.children
if not isinstance(quantile, Literal):
Expand Down
8 changes: 7 additions & 1 deletion python/cudf_polars/tests/test_groupby.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# SPDX-FileCopyrightText: Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES.
# SPDX-FileCopyrightText: Copyright (c) 2024-2025, NVIDIA CORPORATION & AFFILIATES.
# SPDX-License-Identifier: Apache-2.0
from __future__ import annotations

Expand Down Expand Up @@ -213,3 +213,9 @@ def test_groupby_maintain_order_random(nrows, nkeys, with_nulls):
)
q = df.lazy().group_by(key_names, maintain_order=True).agg(pl.col("value").sum())
assert_gpu_result_equal(q)


def test_groupby_len_with_nulls():
df = pl.DataFrame({"a": [1, 1, 1, 2], "b": [1, None, 2, 3]})
q = df.lazy().group_by("a").agg(pl.col("b").len())
assert_gpu_result_equal(q, check_row_order=False)
Loading