Use PyNVML 12 #17627
Merged
Use PyNVML 12 #17627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
jakirkham
added
improvement
|
/ok to test |
|
Will need to update to PyNVML 12 in Dask-CUDA before this will work. CI failures underline this point xref: rapidsai/dask-cuda#1419 |
|
Marking as ready for review. Will rerun CI after the Dask-CUDA PR lands |
jameslamb
reviewed
Dec 20, 2024
|
All good. Wanted to see a rerun as well Mainly stating that for context In any event Dask-CUDA has rebuilt with those changes So have pulled in the latest cuDF changes to refresh the PR and rerun CI. Let's see how it goes |
pentschev
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
LGTM, thanks @jakirkham . Let's get this merged ASAP, as this is blocking cuDF's nightly build-docs.
|
/merge |
raydouglass
approved these changes
Dec 23, 2024
rapids-bot
bot
merged commit f7f7e33
into
rapidsai:branch-25.02
108 of 109 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump
pynvmlfrom11to12. This version ofpynvmlalso now depends onnvidia-ml-pyfor core functionality.Depends on PR: rapidsai/dask-cuda#1419
Checklist