Correctly accept a pandas.CategoricalDtype(pandas.IntervalDtype(...), ...) type
#17604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
bug
bdice
reviewed
Dec 16, 2024
bdice
approved these changes
Dec 16, 2024
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
…ke/cudf into bug/categorical_interval
I amended the unit test to have a test case start the roundtrip from pandas instead of cudf. I think we have OK general test coverage of interval functionality in |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From an offline discussion, a pandas object with an
category[interval[...]]type would be incorrectly be interpreted as acategory[struct[...]]type. This can cause further problems withcudf.pandasas acategory[struct[...]]type cannot be properly interpreted by pandas.Checklist