Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop memory_resource.hpp from including itself #17603

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Stop memory_resource.hpp from including itself #17603

merged 1 commit into from
Dec 17, 2024

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Dec 16, 2024

Description

Resolves #17595

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 16, 2024
@vyasr vyasr self-assigned this Dec 16, 2024
@vyasr vyasr requested a review from a team as a code owner December 16, 2024 22:22
@vyasr vyasr requested review from bdice and ttnghia December 16, 2024 22:22
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Dec 16, 2024
ttnghia
ttnghia approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@ttnghia ttnghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (branch-25.02@a5ac4bf). Learn more about missing BASE report.

Additional details and impacted files 
@@               Coverage Diff               @@
##             branch-25.02   #17603   +/-   ##
===============================================
  Coverage                ?   84.50%           
===============================================
  Files                   ?      232           
  Lines                   ?    33879           
  Branches                ?        0           
===============================================
  Hits                    ?    28630           
  Misses                  ?     5249           
  Partials                ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vyasr
Copy link
Contributor Author

vyasr commented Dec 17, 2024

/merge

@rapids-bot rapids-bot bot merged commit e9e34e6 into branch-25.02 Dec 17, 2024
107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@ttnghia ttnghia ttnghia approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@vyasr vyasr

Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] cudf/utilities/memory_resource.hpp includes itself
3 participants
@vyasr @ttnghia @davidwendt