Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if nightlies have succeeded recently enough #17596

Open
wants to merge 6 commits into
base: branch-25.02
Choose a base branch
from

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Dec 13, 2024

Description

Contributes to rapidsai/build-planning#127

Relies on rapidsai/shared-actions#32

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 13, 2024
@vyasr vyasr self-assigned this Dec 13, 2024
@vyasr vyasr force-pushed the feat/check_nightly_ci branch from cf0dffc to bb8e619 Compare December 13, 2024 23:12
@vyasr vyasr force-pushed the feat/check_nightly_ci branch from 3eef1e2 to e3ca0a9 Compare December 14, 2024 00:23
@rapidsai rapidsai deleted a comment from copy-pr-bot bot Dec 14, 2024
@vyasr vyasr marked this pull request as ready for review December 14, 2024 00:25
@vyasr vyasr requested a review from a team as a code owner December 14, 2024 00:25
@vyasr vyasr requested a review from KyleFromNVIDIA December 14, 2024 00:25
.github/workflows/pr.yaml Outdated Show resolved Hide resolved
@vyasr vyasr requested a review from bdice December 16, 2024 19:59
@vyasr
Copy link
Contributor Author

vyasr commented Dec 16, 2024

Once the PR is approved I'll change the repo name from cugraph to cudf, merge the shared-actions PR and remove the branching here, then rerun CI.

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good! I also approved rapidsai/shared-actions#32.

@vyasr
Copy link
Contributor Author

vyasr commented Dec 17, 2024

Well, we know this works since it immediately picked up that our 25.02 nightlies are failing because of #17611 and #17612! I can merge this tomorrow once those are all handled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants