-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A couple of fixes in rapids-logger usage #17588
A couple of fixes in rapids-logger usage #17588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're pinning to a commit, a shallow clone will start failing as soon as HEAD gets bumped on the main branch
Does CPM clone first and then check out the tag? I would expect it to use git clone -b
, in which case this wouldn't be needed, but if that's how they're doing it then I see why it would be an issue.
CPM isn't doing anything at the git clone stage other than invoking FetchContent. I can replicate the behavior locally if I change my cudf to use commit
Traceback
|
/merge |
Description
This PR has two fixes:
Checklist