Simplify expression transformer in Parquet predicate pushdown with ast::tree
#17587
+24
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
mhaseeb123
changed the title
ast::treeast::tree
mhaseeb123
commented
Dec 13, 2024
| @@ -278,7 +277,6 @@ class stats_expression_converter : public ast::detail::expression_transformer { | |||
| "Statistics AST supports only left table"); | |||
| CUDF_EXPECTS(expr.get_column_index() < _num_columns, | |||
| "Column index cannot be more than number of columns in the table"); | |||
| _stats_expr = std::reference_wrapper<ast::expression const>(expr); | |||
There was a problem hiding this comment.
These don't need to be pushed to the ast::tree since we will be filtering with the new columns in the StatsAST table.
mhaseeb123
added
2 - In Progress
3 tasks
karthikeyann
approved these changes
Dec 13, 2024
|
/ok to test |
mhaseeb123
changed the title
ast::treeast::tree
mhaseeb123
added
3 - Ready for Review
vuule
approved these changes
Dec 13, 2024
mhaseeb123
added
4 - Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR simplifies the StatsAST expression transformer in Parquet reader's predicate pushdown using
ast::treefrom (#17156).This PR is a follow up to @bdice's comment at #17289 (comment). Similar changes for the
BloomfilterASTexpression converter have been incorporated in the PR #17289.Related to #17164
Checklist