Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow large strings in nvtext benchmarks #17579

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Removes the 2GB limit check from the nvtext benchmarks and adjusts the parameters to be consistent across the benchmarks.
Also converts the subword-tokenizer to nvbench and removes the unused word_minhash.cpp source file.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 11, 2024
@davidwendt davidwendt self-assigned this Dec 11, 2024
@davidwendt davidwendt requested a review from a team as a code owner December 11, 2024 20:39
@davidwendt davidwendt requested review from bdice and ttnghia December 11, 2024 20:39
@github-actions github-actions bot added the CMake CMake build issue label Dec 11, 2024
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit a095727 into rapidsai:branch-25.02 Dec 13, 2024
110 checks passed
@davidwendt davidwendt deleted the nvtext-ls-nvbench branch December 13, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - In Progress Currently a work in progress CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants