Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow large strings in nvbench strings benchmarks #17571

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Removes the 2GB limit check from the strings benchmarks and adjusts the parameters to be consistent across the benchmarks.
The default parameters will still not exceed 2GB for automation purposes.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 10, 2024
@davidwendt davidwendt self-assigned this Dec 10, 2024
@davidwendt davidwendt requested a review from a team as a code owner December 10, 2024 20:55
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit f811c38 into rapidsai:branch-25.02 Dec 12, 2024
110 checks passed
@davidwendt davidwendt deleted the large-strings-nvbench branch December 12, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - In Progress Currently a work in progress improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants