Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CMake format in cudf/_lib/CMakeLists.txt #17559

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Fix CMake format in cudf/_lib/CMakeLists.txt #17559

merged 1 commit into from
Dec 10, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Due to 2 of my cudf._lib refactoring PRs going in which then impacted formatting of cudf/_lib/CMakeLists.txt

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 10, 2024
@mroeschke mroeschke self-assigned this Dec 10, 2024
@mroeschke mroeschke requested a review from a team as a code owner December 10, 2024 00:36
@github-actions github-actions bot added Python Affects Python cuDF API. CMake CMake build issue labels Dec 10, 2024
bdice
bdice approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can request an admin-merge on this to unblock CI.

@bdice
Copy link
Contributor

bdice commented Dec 10, 2024

/merge

@rapids-bot rapids-bot bot merged commit c53ace8 into rapidsai:branch-25.02 Dec 10, 2024
103 of 104 checks passed
@mroeschke mroeschke deleted the fix/cmake/stype branch December 10, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@Matt711 Matt711 Awaiting requested review from Matt711 Matt711 is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@mroeschke mroeschke

Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @bdice