-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos, rename types, and add null_probability benchmark axis for distinct #17546
Merged
rapids-bot
merged 5 commits into
rapidsai:branch-25.02
from
PointKernel:cleanup-distinct
Dec 10, 2024
Merged
Fix typos, rename types, and add null_probability benchmark axis for distinct #17546
rapids-bot
merged 5 commits into
rapidsai:branch-25.02
from
PointKernel:cleanup-distinct
Dec 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PointKernel
added
3 - Ready for Review
Ready for review by team
libcudf
Affects libcudf (C++/CUDA) code.
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Dec 6, 2024
mhaseeb123
reviewed
Dec 6, 2024
mhaseeb123
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment but looks good otherwise
mhaseeb123
reviewed
Dec 6, 2024
vyasr
approved these changes
Dec 10, 2024
/ok to test |
/merge |
rapids-bot
bot
merged commit Dec 10, 2024
657f50b
into
rapidsai:branch-25.02
104 of 105 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
improvement
Improvement / enhancement to an existing function
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses several minor issues discovered while working on #17467:
RowHasher
should have beenRowEqual
hash_set_type
todistinct_set_t
null_probability
benchmark axis for the distinct benchmark, similar to other stream compaction benchmarksChecklist