Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos, rename types, and add null_probability benchmark axis for distinct #17546

Merged
merged 5 commits into from
Dec 10, 2024

Conversation

PointKernel
Copy link
Member

Description

This PR addresses several minor issues discovered while working on #17467:

  • Corrected a typo where RowHasher should have been RowEqual
  • Renamed hash_set_type to distinct_set_t
  • Added a null_probability benchmark axis for the distinct benchmark, similar to other stream compaction benchmarks

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@PointKernel PointKernel added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 6, 2024
@PointKernel PointKernel requested a review from a team as a code owner December 6, 2024 21:35
Copy link
Member

@mhaseeb123 mhaseeb123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment but looks good otherwise

@PointKernel
Copy link
Member Author

/ok to test

@PointKernel
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 657f50b into rapidsai:branch-25.02 Dec 10, 2024
104 of 105 checks passed
@PointKernel PointKernel deleted the cleanup-distinct branch December 10, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants