Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark more constexpr functions as device-available #17545

Merged
merged 14 commits into from
Dec 13, 2024
Merged

Mark more constexpr functions as device-available #17545

merged 14 commits into from
Dec 13, 2024

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Dec 6, 2024 •
edited
Loading

Description

Contributes to #7795.

Also contributes to rapidsai/build-planning#76.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 6, 2024
@vyasr vyasr self-assigned this Dec 6, 2024
@vyasr vyasr requested a review from a team as a code owner December 6, 2024 20:05
@vyasr vyasr requested review from harrism and ttnghia December 6, 2024 20:05
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Dec 6, 2024
@vyasr vyasr force-pushed the feat/remove_expt_constexpr branch from bbe6532 to 13433be Compare December 10, 2024 18:27
PointKernel
PointKernel reviewed Dec 11, 2024
View reviewed changes
cpp/include/cudf/detail/utilities/device_operators.cuh Outdated Show resolved Hide resolved
cpp/include/cudf/hashing/detail/hash_functions.cuh Outdated Show resolved Hide resolved
cpp/include/cudf/hashing/detail/hashing.hpp Show resolved Hide resolved
cpp/include/cudf/table/experimental/row_operators.cuh Show resolved Hide resolved
cpp/include/cudf/utilities/traits.hpp Outdated Show resolved Hide resolved
cpp/include/cudf/utilities/traits.hpp Outdated Show resolved Hide resolved
cpp/include/cudf/utilities/traits.hpp Outdated Show resolved Hide resolved
cpp/include/cudf/utilities/traits.hpp Outdated Show resolved Hide resolved
PointKernel
PointKernel reviewed Dec 12, 2024
View reviewed changes
cpp/src/copying/contiguous_split.cu Outdated Show resolved Hide resolved
cpp/src/quantiles/quantiles_util.hpp Outdated Show resolved Hide resolved
cpp/include/cudf/hashing/detail/hash_functions.cuh Outdated Show resolved Hide resolved
cpp/include/cudf/hashing/detail/hash_functions.cuh Show resolved Hide resolved
@vyasr vyasr requested a review from a team as a code owner December 13, 2024 17:30
@vyasr vyasr requested a review from gforsyth December 13, 2024 17:30
PointKernel
PointKernel approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

bdice
bdice approved these changes Dec 13, 2024
View reviewed changes
ci/build_docs.sh Outdated Show resolved Hide resolved
@vyasr
Copy link
Contributor Author

vyasr commented Dec 13, 2024

/merge

@rapids-bot rapids-bot bot merged commit 34e2045 into rapidsai:branch-25.02 Dec 13, 2024
105 checks passed
@vyasr vyasr mentioned this pull request Dec 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@PointKernel PointKernel PointKernel approved these changes

@ttnghia ttnghia ttnghia approved these changes

@bdice bdice bdice approved these changes

@harrism harrism Awaiting requested review from harrism harrism is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@gforsyth gforsyth Awaiting requested review from gforsyth gforsyth is a code owner automatically assigned from rapidsai/ci-codeowners

Assignees

@vyasr vyasr

Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vyasr @bdice @ttnghia @PointKernel @davidwendt