Fix nvcc-imposed UB in constexpr functions
#17534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
…vuule/cudf into remove-constexpr-with-cudf_fail
|
/ok to test |
karthikeyann
approved these changes
Dec 6, 2024
mythrocks
approved these changes
Dec 6, 2024
|
Perhaps this is related to #7795 |
davidwendt
approved these changes
Dec 6, 2024
bdice
approved these changes
Dec 6, 2024
|
There's definitely some overlap with #7795, but, AFAIK, that issue is related to device functions that include a throw. |
hyperbolic2346
approved these changes
Dec 6, 2024
vuule
changed the title
constexpr functions
PointKernel
approved these changes
Dec 6, 2024
davidwendt
approved these changes
Dec 6, 2024
mythrocks
approved these changes
Dec 6, 2024
mythrocks
reviewed
Dec 7, 2024
mhaseeb123
approved these changes
Dec 7, 2024
|
/merge |
rapids-bot
bot
merged commit ba3ed57
into
rapidsai:branch-25.02
104 of 105 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
nvcc does not support
constexprfunctions that are not well-defined to call from the device. This is UB even when the function is not called from the device.Throwing an exception is one such operation. This PR cleans up error handling for functions that are called from device, and removes
constexprfrom the ones that are not actually used from the device, or in the constexpr context.Checklist