Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add anonymous namespace to libcudf test source #17529

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Uses anonymous namespace declaration on internal only functions and structures in the libcudf gtest source. This helps prevent odd nvcc compile errors like the one described in #17432

Closes #17432

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Dec 5, 2024
@davidwendt davidwendt self-assigned this Dec 5, 2024
Copy link

copy-pr-bot bot commented Dec 5, 2024

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@davidwendt
Copy link
Contributor Author

/ok to test

@davidwendt
Copy link
Contributor Author

/ok to test

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Dec 6, 2024
@davidwendt davidwendt marked this pull request as ready for review December 6, 2024 15:13
@davidwendt davidwendt requested a review from a team as a code owner December 6, 2024 15:13
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change. Perhaps we should also be adding some symbol visibility markup to cudf::tests functions if they are causing further problems? It looks like the function Nghia originally ran into was in the test util and not a test.

@davidwendt
Copy link
Contributor Author

Good change. Perhaps we should also be adding some symbol visibility markup to cudf::tests functions if they are causing further problems? It looks like the function Nghia originally ran into was in the test util and not a test.

I think that is something separate to consider but the visibility issue here was in the global namespace and not in the cudf::test one. I believe the error in the linked issue was just a unfortunate side-effect which would not have been fixed by hiding the cudf::test symbols.

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 98d9856 into rapidsai:branch-25.02 Dec 12, 2024
105 checks passed
@davidwendt davidwendt deleted the anon-namespace-gtests branch December 12, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Cannot use cudf::test::iterators::nulls_at () in .cu test file
3 participants