-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add anonymous namespace to libcudf test source #17529
Add anonymous namespace to libcudf test source #17529
Conversation
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
/ok to test |
/ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good change. Perhaps we should also be adding some symbol visibility markup to cudf::tests
functions if they are causing further problems? It looks like the function Nghia originally ran into was in the test util and not a test.
I think that is something separate to consider but the visibility issue here was in the global namespace and not in the |
/merge |
Description
Uses anonymous namespace declaration on internal only functions and structures in the libcudf gtest source. This helps prevent odd nvcc compile errors like the one described in #17432
Closes #17432
Checklist