Propagate failures in pandas integration tests and Skip failing tests #17521

Matt711 · 2024-12-04T23:22:54Z

Description

This PR ensures that the integration tests fail in any one of the test modules fails. It also skips of xfails any tests that are not currently passing. Finally, it fixes one incorrect use of rng.random.

Some of the change were originally made in #17489

Checklist

I am familiar with the Contributing Guidelines.
New or existing tests cover these changes.
The documentation is up to date with these changes.

…mn.from_libcudf

Matt711 · 2024-12-05T23:26:23Z

For the reviewer, I'll follow-up this PR to fix failing tests. xref #17490

python/cudf/cudf_pandas_tests/third_party_integration_tests/tests/test_xgboost.py

python/cudf/cudf_pandas_tests/third_party_integration_tests/tests/test_tensorflow.py

python/cudf/cudf_pandas_tests/third_party_integration_tests/tests/test_seaborn.py

python/cudf/cudf_pandas_tests/third_party_integration_tests/tests/test_pytorch.py

python/cudf/cudf_pandas_tests/third_party_integration_tests/tests/test_numpy.py

python/cudf/cudf_pandas_tests/third_party_integration_tests/tests/test_matplotlib.py

python/cudf/cudf_pandas_tests/third_party_integration_tests/tests/test_holoviews.py

…sts/test_xgboost.py

…sts/test_tensorflow.py

…sts/test_seaborn.py

…sts/test_pytorch.py

…sts/test_numpy.py

…sts/test_matplotlib.py

…sts/test_holoviews.py

python/cudf/cudf_pandas_tests/third_party_integration_tests/tests/test_xgboost.py

vyasr

Is the plan to merge this after we add xfails? Sorry I think I've lost track of the various discussions we've had, I know I've asked this a couple of times already.

Matt711 · 2024-12-10T02:46:07Z

Is the plan to merge this after we add xfails? Sorry I think I've lost track of the various discussions we've had, I know I've asked this a couple of times already.

Yes that is still the plan. A few of the tests that are failing with "AttributeError: 'ndarray' object has no attribute '_fsproxy_wrapped'" are giving me some weird problems. They fail when run normally and XPASS when I add @pytest.mark.xfail. I'm going to look at these failures more closely tomorrow. And my apologies, I meant to update you earlier today.

python/cudf/cudf_pandas_tests/third_party_integration_tests/tests/test_catboost.py

…sts/test_catboost.py

python/cudf/cudf_pandas_tests/third_party_integration_tests/tests/test_catboost.py

Matt711

Tests are finally passing, but there's a lot more work to do here in #17490. CC. @vyasr

Matt711 · 2024-12-12T14:32:37Z

python/cudf/cudf_pandas_tests/third_party_integration_tests/tests/test_catboost.py

@@ -1,129 +0,0 @@
-# Copyright (c) 2024, NVIDIA CORPORATION.


I'm getting strange errors in the catboost test suite. Pytest fails to collect the tests with this error.

ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject

From a cursory investigation, it may be due to the version of NumPy installed that's causing problems. I tried skipping the tests but it still fails. I'm deleting the tests for now and will make it priority to add them back in #17490.

This is probably due to ABI incompatibility between the version of NumPy that catboost is compiled against and the version of of NumPy installed in test CI job.

Matt711 · 2024-12-12T14:33:45Z

.github/workflows/pr.yaml

@@ -40,6 +40,7 @@ jobs:
      - pandas-tests
      - pandas-tests-diff
      - telemetry-setup
+      - third-party-integration-tests-cudf-pandas


I'll delete these changes to pr.yaml once this PR is approved. I only added them to run the CI job in this PR.

vyasr · 2024-12-12T18:11:09Z

Why delete catboost? It looks like the failure is a runtime issue and not like a seg fault, so can't you just mark the test as a skip?

vyasr · 2024-12-12T18:23:57Z

Discussed offline, this test still seems to make the suite fail even if it is skipped so we'll drop it for now and add back in a follow-up.

.github/workflows/pr.yaml

Matt711 · 2024-12-12T21:33:14Z

/merge

Matt711 · 2024-12-13T02:46:14Z

/merge

Matt711 added 3 commits December 4, 2024 13:31

Replaces uses of cudf._lib.Column.from_unique_ptr with pylibcudf.Colu…

0ee9ac0

…mn.from_libcudf

migrate changes from Propagate failures in pandas integration tests

76315b0

clean up

719da3a

Matt711 requested review from a team as code owners December 4, 2024 23:22

Matt711 requested review from KyleFromNVIDIA, wence- and mroeschke December 4, 2024 23:22

github-actions bot assigned Matt711 Dec 4, 2024

github-actions bot added Python Affects Python cuDF API. cudf.pandas Issues specific to cudf.pandas labels Dec 4, 2024

Matt711 mentioned this pull request Dec 4, 2024

Propagate failures in pandas integration tests #17497

Closed

3 tasks

Matt711 added non-breaking Non-breaking change bug Something isn't working labels Dec 4, 2024

Merge branch 'branch-25.02' into fix/pandas/third-party-tests

f4be114

Matt711 and others added 5 commits December 5, 2024 18:48

remove deleted line

29798e9

add to ci job

5b870f4

Merge branch 'branch-25.02' into fix/pandas/third-party-tests

eff6883

xfail failing tests

30a9391

remove xdist worksteal strategy

ce69e26

Matt711 commented Dec 7, 2024

View reviewed changes

Matt711 added 8 commits December 7, 2024 09:03

Update python/cudf/cudf_pandas_tests/third_party_integration_tests/te…

4c327b2

…sts/test_xgboost.py

Update python/cudf/cudf_pandas_tests/third_party_integration_tests/te…

581f938

…sts/test_tensorflow.py

Update python/cudf/cudf_pandas_tests/third_party_integration_tests/te…

688a561

…sts/test_seaborn.py

Update python/cudf/cudf_pandas_tests/third_party_integration_tests/te…

a47fb4f

…sts/test_pytorch.py

Update python/cudf/cudf_pandas_tests/third_party_integration_tests/te…

dcd54e4

…sts/test_numpy.py

Update python/cudf/cudf_pandas_tests/third_party_integration_tests/te…

8090316

…sts/test_matplotlib.py

Update python/cudf/cudf_pandas_tests/third_party_integration_tests/te…

22cc708

…sts/test_holoviews.py

Update python/cudf/cudf_pandas_tests/third_party_integration_tests/te…

725bcf3

…sts/test_holoviews.py

Matt711 and others added 2 commits December 7, 2024 09:04

Merge branch 'branch-25.02' into fix/pandas/third-party-tests

39b24cc

fix a bug and xfail a test

5106ab5

Matt711 commented Dec 9, 2024

View reviewed changes

python/cudf/cudf_pandas_tests/third_party_integration_tests/tests/test_xgboost.py Outdated Show resolved Hide resolved

remove get call

75641d5

vyasr reviewed Dec 10, 2024

View reviewed changes

Matt711 added 2 commits December 11, 2024 07:55

skip tests

5b11e66

import or skip catboost

0b4f5fa

Matt711 commented Dec 11, 2024

View reviewed changes

python/cudf/cudf_pandas_tests/third_party_integration_tests/tests/test_catboost.py Outdated Show resolved Hide resolved

Update python/cudf/cudf_pandas_tests/third_party_integration_tests/te…

4a2f78a

…sts/test_catboost.py

Matt711 commented Dec 12, 2024

View reviewed changes

python/cudf/cudf_pandas_tests/third_party_integration_tests/tests/test_catboost.py Outdated Show resolved Hide resolved

Matt711 and others added 3 commits December 11, 2024 19:08

clean up

3d70643

ignore catboost tests

ead0792

remove catboost tests

93d15a9

Matt711 commented Dec 12, 2024

View reviewed changes

Matt711 requested a review from vyasr December 12, 2024 15:18

Matt711 changed the title ~~Propagate failures in pandas integration tests~~ Propagate failures in pandas integration tests and Skip failing tests Dec 12, 2024

vyasr approved these changes Dec 12, 2024

View reviewed changes

Matt711 commented Dec 12, 2024

View reviewed changes

.github/workflows/pr.yaml Outdated Show resolved Hide resolved

.github/workflows/pr.yaml Outdated Show resolved Hide resolved

Matt711 added 2 commits December 12, 2024 16:32

Update .github/workflows/pr.yaml

f2e7eb0

Update .github/workflows/pr.yaml

80ea00e

rapids-bot bot merged commit 5baaf6d into rapidsai:branch-25.02 Dec 13, 2024
104 of 105 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Propagate failures in pandas integration tests and Skip failing tests #17521

Propagate failures in pandas integration tests and Skip failing tests #17521

Matt711 commented Dec 4, 2024 •

edited

Loading

Matt711 commented Dec 5, 2024

vyasr left a comment •

edited

Loading

Matt711 commented Dec 10, 2024

Matt711 left a comment

Matt711 Dec 12, 2024

Matt711 Dec 12, 2024

Matt711 Dec 12, 2024

vyasr commented Dec 12, 2024

vyasr commented Dec 12, 2024

Matt711 commented Dec 12, 2024

Matt711 commented Dec 13, 2024

Propagate failures in pandas integration tests and Skip failing tests #17521

Propagate failures in pandas integration tests and Skip failing tests #17521

Conversation

Matt711 commented Dec 4, 2024 • edited Loading

Description

Checklist

Matt711 commented Dec 5, 2024

vyasr left a comment • edited Loading

Choose a reason for hiding this comment

Matt711 commented Dec 10, 2024

Matt711 left a comment

Choose a reason for hiding this comment

Matt711 Dec 12, 2024

Choose a reason for hiding this comment

Matt711 Dec 12, 2024

Choose a reason for hiding this comment

Matt711 Dec 12, 2024

Choose a reason for hiding this comment

vyasr commented Dec 12, 2024

vyasr commented Dec 12, 2024

Matt711 commented Dec 12, 2024

Matt711 commented Dec 13, 2024

Matt711 commented Dec 4, 2024 •

edited

Loading

vyasr left a comment •

edited

Loading