Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cudf::detail::copy_if logic with thrust::copy_if and gather #17520

Merged
merged 6 commits into from
Dec 10, 2024
Merged

Replace cudf::detail::copy_if logic with thrust::copy_if and gather #17520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0764c01
Replace cudf::detail::copy_if logic with thrust::copy_if and gather
davidwendt Dec 4, 2024
2adfd59
Merge branch 'branch-25.02' into copy-if-use-thrust
davidwendt Dec 5, 2024
83c890c
Merge branch 'branch-25.02' into copy-if-use-thrust
davidwendt Dec 6, 2024
9c689df
add more benchmark values to apply-boolean-mask
davidwendt Dec 6, 2024
3c13cab
Merge branch 'branch-25.02' into copy-if-use-thrust
davidwendt Dec 6, 2024
feef10d
remove unneeded include
davidwendt Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cpp/benchmarks/stream_compaction/apply_boolean_mask.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ void apply_boolean_mask_benchmark(nvbench::state& state, nvbench::type_list<Data
data_profile profile = data_profile_builder().cardinality(0).no_validity().distribution(
input_type, distribution_id::UNIFORM, 0, 20);

auto source_table =
create_random_table(cycle_dtypes({input_type}, n_cols), row_count{n_rows}, profile);
auto source_table = create_random_table(
cycle_dtypes({input_type, cudf::type_id::STRING}, n_cols), row_count{n_rows}, profile);

profile.set_bool_probability_true(percent_true / 100.0);
profile.set_null_probability(std::nullopt); // no null mask
Expand All @@ -85,6 +85,6 @@ using data_type = nvbench::type_list<int32_t, int64_t, double, cudf::string_view
NVBENCH_BENCH_TYPES(apply_boolean_mask_benchmark, NVBENCH_TYPE_AXES(data_type))
.set_name("apply_boolean_mask")
.set_type_axes_names({"type"})
.add_int64_axis("columns", {1, 4})
.add_int64_axis("columns", {1, 4, 9})
.add_int64_axis("rows", {100'000, 1'000'000, 10'000'000})
.add_int64_axis("hits_%", {10, 50, 100});
.add_int64_axis("hits_%", {10, 20, 50, 80, 90, 100});
Loading
Loading