Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dask-cuDF clip APIs #17509

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Conversation

rjzamora
Copy link
Member

@rjzamora rjzamora commented Dec 4, 2024

Description

Closes #17502

Background Info: The cudf and pandas axis defaults are different, and the upstream dask-expr clip APIs are consistent with the behavior of Pandas (not cudf).

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@rjzamora rjzamora added bug Something isn't working 2 - In Progress Currently a work in progress dask Dask issue non-breaking Non-breaking change labels Dec 4, 2024
@rjzamora rjzamora self-assigned this Dec 4, 2024
@rjzamora rjzamora requested a review from a team as a code owner December 4, 2024 15:25
@github-actions github-actions bot added the Python Affects Python cuDF API. label Dec 4, 2024
@rjzamora rjzamora added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 2 - In Progress Currently a work in progress labels Dec 9, 2024
@rjzamora rjzamora added 2 - In Progress Currently a work in progress and removed 5 - Ready to Merge Testing and reviews complete, ready to merge labels Dec 9, 2024
@Matt711
Copy link
Contributor

Matt711 commented Dec 10, 2024

/merge

@rapids-bot rapids-bot bot merged commit 1e95864 into rapidsai:branch-25.02 Dec 10, 2024
104 of 105 checks passed
@rjzamora rjzamora deleted the dask-cudf-clip branch December 11, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - In Progress Currently a work in progress bug Something isn't working dask Dask issue non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] clip not implemented for Dask-cuDF
3 participants