Remove cudf._lib.transform in favor of inlining pylibcudf #17505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
… into cudf/_lib/transform
Matt711
approved these changes
Dec 9, 2024
| @@ -7883,6 +7881,16 @@ def interleave_columns(self): | |||
| ) | |||
| return self._constructor_sliced._from_column(result_col) | |||
|
|
|||
| @acquire_spill_lock() | |||
| def _compute_columns(self, expr: str) -> ColumnBase: | |||
There was a problem hiding this comment.
Suggesting because it returns one column
Suggested change
| def _compute_columns(self, expr: str) -> ColumnBase: | |
| def _compute_column(self, expr: str) -> ColumnBase: |
There was a problem hiding this comment.
Sure, that makes sense. I'll incorporate this in another PR just to save a CI run
There was a problem hiding this comment.
I incorporated it in #17456
| [*self._columns], self._column_names, statements[0] | ||
| ) | ||
| ) | ||
| return Series._from_column(self._compute_columns(statements[0])) |
There was a problem hiding this comment.
Suggested change
| return Series._from_column(self._compute_columns(statements[0])) | |
| return Series._from_column(self._compute_column(statements[0])) |
| for name, col in zip(targets, cols): | ||
| ret._data[name] = col | ||
| for name, expr in zip(targets, exprs): | ||
| ret._data[name] = self._compute_columns(expr) |
There was a problem hiding this comment.
Suggested change
| ret._data[name] = self._compute_columns(expr) | |
| ret._data[name] = self._compute_column(expr) |
|
/merge |
rapids-bot
bot
merged commit 9df95d1
into
rapidsai:branch-25.02
104 of 105 checks passed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to #17317
Checklist