Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cudf._lib.string.convert/split in favor of inlining pylibcudf #17496

Merged
merged 6 commits into from
Dec 9, 2024
Merged

Remove cudf._lib.string.convert/split in favor of inlining pylibcudf #17496

merged 6 commits into from
Dec 9, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Contributes to #17317

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 3, 2024
@mroeschke mroeschke self-assigned this Dec 3, 2024
@mroeschke mroeschke requested a review from a team as a code owner December 3, 2024 21:09
@mroeschke mroeschke requested review from wence- and Matt711 December 3, 2024 21:09
@github-actions github-actions bot added the CMake CMake build issue label Dec 3, 2024
Matt711
Matt711 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@Matt711 Matt711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Just a question about a deleted TODO comment

python/cudf/cudf/core/tools/numeric.py Show resolved Hide resolved
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit f595592 into rapidsai:branch-25.02 Dec 9, 2024
104 of 105 checks passed
@mroeschke mroeschke deleted the cudf/_lib/string branch December 9, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matt711 Matt711 Matt711 approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@mroeschke mroeschke

Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @Matt711