Migrate cudf::io::merge_row_group_metadata to pylibcudf
#17491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
github-actions
bot
added
Python
Matt711
added
feature request
github-actions
bot
added
Python
mroeschke
reviewed
Dec 3, 2024
| ] | ||
|
|
||
|
|
||
| cdef class BufferArrayFromVector: |
There was a problem hiding this comment.
You can probably reuse HostBuffer from contiguous_split.pyx
mroeschke
reviewed
Dec 3, 2024
| @@ -577,3 +612,34 @@ cpdef memoryview write_parquet(ParquetWriterOptions options): | |||
| c_result = cpp_write_parquet(c_options) | |||
|
|
|||
| return memoryview(HostBuffer.from_unique_ptr(move(c_result))) | |||
|
|
|||
|
|
|||
| cpdef BufferArrayFromVector merge_row_group_metadata(list metdata_list): | |||
There was a problem hiding this comment.
Similar to write_parquet, I think we want to return a memoryview here
|
/ok to test |
|
/ok to test |
mroeschke
approved these changes
Dec 4, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apart of #15162
Checklist