Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add num_rows to metadata in JSON reader #17480

Draft
wants to merge 1 commit into
base: branch-25.02
Choose a base branch
from
Draft

Add num_rows to metadata in JSON reader #17480

wants to merge 1 commit into from

Conversation

karthikeyann
Copy link
Contributor

Description

Part of #5712

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@karthikeyann karthikeyann added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. cuIO cuIO issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 2, 2024
@karthikeyann karthikeyann added this to the Nested JSON reader milestone Dec 2, 2024
@karthikeyann karthikeyann self-assigned this Dec 2, 2024
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 2, 2024

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@karthikeyann karthikeyann requested a review from shrshi December 3, 2024 02:07
@karthikeyann
Copy link
Contributor Author

@shrshi Since multiple sources could be combined per batch, or same source might span multiple batches, This PR needs rework of batching, and to return right num_rows_per_source.

@GregoryKimball GregoryKimball mentioned this pull request Jan 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrshi shrshi Awaiting requested review from shrshi

At least 1 approving review is required to merge this pull request.

Assignees

@karthikeyann karthikeyann

Labels
2 - In Progress Currently a work in progress cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
libcudf
Status: No status
Milestone
Nested JSON reader
Development

Successfully merging this pull request may close these issues.
1 participant
@karthikeyann