Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cudf._lib.binops in favor of inlining pylibcudf #17468

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Remove cudf._lib.binops in favor of inlining pylibcudf #17468

merged 4 commits into from
Dec 4, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Contributes to #17317

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 28, 2024
@mroeschke mroeschke self-assigned this Nov 28, 2024
@mroeschke mroeschke requested a review from a team as a code owner November 28, 2024 01:48
@mroeschke mroeschke requested review from vyasr and Matt711 November 28, 2024 01:48
@github-actions github-actions bot added the CMake CMake build issue label Nov 28, 2024
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 351ece5 into rapidsai:branch-25.02 Dec 4, 2024
105 checks passed
@mroeschke mroeschke deleted the cudf/_lib/binops branch December 4, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@Matt711 Matt711 Awaiting requested review from Matt711 Matt711 is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@mroeschke mroeschke

Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @galipremsagar