Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test primitive row operator #17467

Draft
wants to merge 9 commits into
base: branch-25.02
Choose a base branch
from
Draft

Test primitive row operator #17467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f2015f1
Add primitive_row_operator header
PointKernel Nov 26, 2024
f1cc450
Cleanups
PointKernel Nov 26, 2024
2afb3bb
Merge remote-tracking branch 'upstream/branch-25.02' into primitive-r…
PointKernel Nov 27, 2024
20d5273
Merge remote-tracking branch 'upstream/branch-25.02' into primitive-r…
PointKernel Nov 27, 2024
d8ca317
Merge remote-tracking branch 'upstream/branch-25.02' into primitive-r…
PointKernel Nov 27, 2024
0670a36
Update distinct benchmark to add null_probability axis
PointKernel Nov 27, 2024
ab56bdb
Fix a typo
PointKernel Nov 27, 2024
6e3ab5f
Minor fixes
PointKernel Nov 27, 2024
849fe60
First working prototype
PointKernel Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cpp/benchmarks/stream_compaction/distinct.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ void nvbench_distinct(nvbench::state& state, nvbench::type_list<Type>)
cudf::size_type const num_rows = state.get_int64("NumRows");
auto const keep = get_keep(state.get_string("keep"));
cudf::size_type const cardinality = state.get_int64("cardinality");
auto const null_probability = state.get_float64("null_probability");

if (cardinality > num_rows) {
state.skip("cardinality > num_rows");
Expand All @@ -42,7 +43,7 @@ void nvbench_distinct(nvbench::state& state, nvbench::type_list<Type>)

data_profile profile = data_profile_builder()
.cardinality(cardinality)
.null_probability(0.01)
.null_probability(null_probability)
.distribution(cudf::type_to_id<Type>(),
distribution_id::UNIFORM,
static_cast<Type>(0),
Expand All @@ -65,6 +66,7 @@ using data_type = nvbench::type_list<int32_t, int64_t>;
NVBENCH_BENCH_TYPES(nvbench_distinct, NVBENCH_TYPE_AXES(data_type))
.set_name("distinct")
.set_type_axes_names({"Type"})
.add_float64_axis("null_probability", {0.01})
.add_string_axis("keep", {"any", "first", "last", "none"})
.add_int64_axis("cardinality", {100, 100'000, 10'000'000, 1'000'000'000})
.add_int64_axis("NumRows", {100, 100'000, 10'000'000, 1'000'000'000});
Expand Down
Loading