Set build type for all examples #17463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
improvement
github-actions
bot
added
libcudf
bdice
approved these changes
Nov 27, 2024
| @@ -15,6 +15,9 @@ project( | |||
|
|
|||
| include(../fetch_dependencies.cmake) | |||
|
|
|||
| include(rapids-cmake) | |||
| rapids_cmake_build_type("Release") | |||
|
|
|||
| # The Arrow CMake is currently broken if the build type is not set | |||
| set(CMAKE_BUILD_TYPE Release) | |||
There was a problem hiding this comment.
I'll test locally and see. I'm not sure.
There was a problem hiding this comment.
Oh I guess I filed a fix for this in apache/arrow#43794. I think it made it into Arrow 18, so we can't drop this until we switch to requiring that version (we currently use 16.1). We could upgrade any time we wanted though since the library used for these builds is no longer tied to libcudf itself in any way. I'd be fine with a follow-up PR to upgrade that value and remove this setting.
mhaseeb123
approved these changes
Nov 27, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The examples currently have no build type set by default so they wind up with debug code in them.
Checklist