-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the hook versions in pre-commit #17462
Merged
rapids-bot
merged 20 commits into
rapidsai:branch-25.02
from
wence-:wence/chore/pre-commit-upgrade
Dec 2, 2024
Merged
Update the hook versions in pre-commit #17462
rapids-bot
merged 20 commits into
rapidsai:branch-25.02
from
wence-:wence/chore/pre-commit-upgrade
Dec 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this was always supposed to be checking for set membership, not equality.
github-actions
bot
added
libcudf
Affects libcudf (C++/CUDA) code.
Python
Affects Python cuDF API.
cudf.pandas
Issues specific to cudf.pandas
cudf.polars
Issues specific to cudf.polars
pylibcudf
Issues specific to the pylibcudf package
labels
Nov 27, 2024
bdice
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed library code and skimmed test code. All looks good.
Matt711
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one non-blocking suggestion
AyodeAwe
approved these changes
Nov 27, 2024
Co-authored-by: Matthew Murray <[email protected]>
wence-
added
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Nov 27, 2024
/merge |
wence-
commented
Nov 28, 2024
We can't do this change because numpy dtypes override __eq__.
ttnghia
approved these changes
Nov 29, 2024
rjzamora
approved these changes
Dec 2, 2024
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cudf.pandas
Issues specific to cudf.pandas
cudf.polars
Issues specific to cudf.polars
improvement
Improvement / enhancement to an existing function
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
pylibcudf
Issues specific to the pylibcudf package
Python
Affects Python cuDF API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The major change here is to move to ruff 0.8 which, among other things, introduces automatic sorting for
__all__
and__slots__
(so I've turned those on and fixed things).Notable actual bug fix: b2cfb9c
Checklist