Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the hook versions in pre-commit #17462

Merged

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Nov 27, 2024

Description

The major change here is to move to ruff 0.8 which, among other things, introduces automatic sorting for __all__ and __slots__ (so I've turned those on and fixed things).

Notable actual bug fix: b2cfb9c

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence- wence- requested review from a team as code owners November 27, 2024 12:31
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. cudf.pandas Issues specific to cudf.pandas cudf.polars Issues specific to cudf.polars pylibcudf Issues specific to the pylibcudf package labels Nov 27, 2024
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed library code and skimmed test code. All looks good.

Copy link
Contributor

@Matt711 Matt711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one non-blocking suggestion

python/cudf/cudf/tests/test_groupby.py Outdated Show resolved Hide resolved
@wence- wence- added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 27, 2024
@wence-
Copy link
Contributor Author

wence- commented Nov 27, 2024

/merge

@vyasr
Copy link
Contributor

vyasr commented Dec 2, 2024

/merge

@rapids-bot rapids-bot bot merged commit d1bad33 into rapidsai:branch-25.02 Dec 2, 2024
108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cudf.pandas Issues specific to cudf.pandas cudf.polars Issues specific to cudf.polars improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants