Update MurmurHash3_x64_128 to use the cuco equivalent implementation #17457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PointKernel
added
3 - Ready for Review
karthikeyann
approved these changes
Nov 27, 2024
mythrocks
reviewed
Nov 27, 2024
ttnghia
reviewed
Dec 1, 2024
| template <typename Key> | ||
| struct MurmurHash3_x64_128 { | ||
| using result_type = thrust::pair<uint64_t, uint64_t>; | ||
| using result_type = cuda::std::array<uint64_t, 2>; |
There was a problem hiding this comment.
Is there any benefit from this change?
There was a problem hiding this comment.
cuda::std::array is the proper type.
In the original implementation, the output was an array of two elements. Since cuda::std::array was not available when the hasher was introduced into libcudf, we used thrust::pair instead. Looking ahead, if we adopt more 128-bit hashers where the return type could consist of four 32-bit integers, cuda::std::array would still be a suitable choice, whereas thrust::pair would not.
ttnghia
approved these changes
Dec 2, 2024
bdice
approved these changes
Dec 2, 2024
mythrocks
approved these changes
Dec 2, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies MurmurHash3_x64_128 to utilize the cuco equivalent implementation, eliminating duplication.
Checklist