Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to rmm logger changes #17451

Merged
merged 6 commits into from
Nov 27, 2024
Merged

Adapt to rmm logger changes #17451

merged 6 commits into from
Nov 27, 2024

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Nov 26, 2024

Description

This PR adapts to breaking changes in rmm in rapidsai/rmm#1722.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added the improvement Improvement / enhancement to an existing function label Nov 26, 2024
@vyasr vyasr self-assigned this Nov 26, 2024
@vyasr vyasr requested a review from a team as a code owner November 26, 2024 19:19
@vyasr vyasr added the non-breaking Non-breaking change label Nov 26, 2024
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Nov 26, 2024
@vyasr vyasr requested a review from a team as a code owner November 27, 2024 01:48
@vyasr vyasr requested a review from bdice November 27, 2024 01:48
@vyasr vyasr added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Nov 27, 2024
@vyasr vyasr removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Nov 27, 2024
@vyasr vyasr removed the request for review from a team November 27, 2024 15:38
@vyasr
Copy link
Contributor Author

vyasr commented Nov 27, 2024

/merge

@rapids-bot rapids-bot bot merged commit 0495071 into rapidsai:branch-25.02 Nov 27, 2024
106 of 125 checks passed
@vyasr vyasr deleted the feat/rmm_logger branch November 27, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@harrism harrism harrism approved these changes

@bdice bdice Awaiting requested review from bdice bdice was automatically assigned from rapidsai/ci-codeowners

Assignees

@vyasr vyasr

Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vyasr @harrism @ttnghia