Update MurmurHash3_x86_32 to use the cuco equivalent implementation #17429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PointKernel
added
2 - In Progress
PointKernel
force-pushed
the
cleanup-murmurhash-32
branch
from
fbe4c7f to
278eb1f
Compare
PointKernel
added
3 - Ready for Review
bdice
reviewed
Nov 25, 2024
bdice
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
This is fine, though I had to rethink my own views on how the hashers work. Thanks @PointKernel for explaining the pitfalls in my expectations.
lamarrr
reviewed
Nov 26, 2024
lamarrr
approved these changes
Nov 26, 2024
3 tasks
mhaseeb123
approved these changes
Nov 26, 2024
3 tasks
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 28, 2024
Incorporate the review suggestions from #17429 into xxhash_64 to clean up the code. Authors: - Yunsong Wang (https://github.com/PointKernel) - Muhammad Haseeb (https://github.com/mhaseeb123) Approvers: - Bradley Dice (https://github.com/bdice) - Muhammad Haseeb (https://github.com/mhaseeb123) - Basit Ayantunde (https://github.com/lamarrr) URL: #17455
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies
MurmurHash3_x86_32to utilize the cuco equivalent implementation, eliminating duplication. Additionally, it resolves a minor issue inxxhash_64where the seed was not correctly passed to the underlying implementation.Checklist