Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nvtx/ranges.hpp include from cuda.cuh #17427

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Remove nvtx/ranges.hpp include from cuda.cuh #17427

merged 3 commits into from
Nov 26, 2024

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Nov 23, 2024 •
edited
Loading

Description

Removes unused header include nvtx/ranges.hpp from cuda.cuh and fixes up all the source files that were dependent on this include.
Found while trying to include cuda.cuh in a jit'd kernel source.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 23, 2024
@davidwendt davidwendt self-assigned this Nov 23, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Nov 25, 2024
@davidwendt davidwendt marked this pull request as ready for review November 25, 2024 16:12
@davidwendt davidwendt requested a review from a team as a code owner November 25, 2024 16:12
@davidwendt davidwendt requested review from harrism and vuule November 25, 2024 16:12
bdice
bdice approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One fix, otherwise LGTM. Very good to fix this.

cpp/include/cudf/detail/utilities/cuda.cuh Show resolved Hide resolved
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit f5954a4 into rapidsai:branch-25.02 Nov 26, 2024
105 checks passed
@davidwendt davidwendt deleted the fix-cudah-includes branch November 26, 2024 17:04
@jlowe jlowe mentioned this pull request Nov 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@bdice bdice bdice approved these changes

@harrism harrism Awaiting requested review from harrism harrism is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@vuule vuule Awaiting requested review from vuule vuule is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @bdice @ttnghia