Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some cudf._lib.strings files in favor of inlining pylibcudf #17394

Merged
merged 6 commits into from
Nov 27, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 1 addition & 21 deletions python/cudf/cudf/_lib/strings/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,27 +12,7 @@
# the License.
# =============================================================================

set(cython_sources
attributes.pyx
capitalize.pyx
case.pyx
char_types.pyx
combine.pyx
contains.pyx
extract.pyx
find.pyx
find_multiple.pyx
findall.pyx
json.pyx
padding.pyx
repeat.pyx
replace.pyx
replace_re.pyx
strip.pyx
substring.pyx
translate.pyx
wrap.pyx
)
set(cython_sources)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if there is no more Cython source, we can delete lines 15-22.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah great. Yes can remove this here


set(linked_libraries cudf::cudf)
rapids_cython_create_modules(
Expand Down
56 changes: 0 additions & 56 deletions python/cudf/cudf/_lib/strings/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,62 +32,10 @@
detokenize,
tokenize_with_vocabulary,
)
from cudf._lib.strings.attributes import (
code_points,
count_bytes,
count_characters,
)
from cudf._lib.strings.capitalize import capitalize, is_title, title
from cudf._lib.strings.case import swapcase, to_lower, to_upper
from cudf._lib.strings.char_types import (
filter_alphanum,
is_alnum,
is_alpha,
is_decimal,
is_digit,
is_lower,
is_numeric,
is_space,
is_upper,
)
from cudf._lib.strings.combine import (
concatenate,
join,
join_lists_with_column,
join_lists_with_scalar,
)
from cudf._lib.strings.contains import contains_re, count_re, like, match_re
from cudf._lib.strings.convert.convert_fixed_point import to_decimal
from cudf._lib.strings.convert.convert_floats import is_float
from cudf._lib.strings.convert.convert_integers import is_integer
from cudf._lib.strings.convert.convert_urls import url_decode, url_encode
from cudf._lib.strings.extract import extract
from cudf._lib.strings.find import (
contains,
contains_multiple,
endswith,
endswith_multiple,
find,
rfind,
startswith,
startswith_multiple,
)
from cudf._lib.strings.find_multiple import find_multiple
from cudf._lib.strings.findall import find_re, findall
from cudf._lib.strings.json import get_json_object
from cudf._lib.strings.padding import center, ljust, pad, rjust, zfill
from cudf._lib.strings.repeat import repeat_scalar, repeat_sequence
from cudf._lib.strings.replace import (
insert,
replace,
replace_multi,
slice_replace,
)
from cudf._lib.strings.replace_re import (
replace_multi_re,
replace_re,
replace_with_backrefs,
)
from cudf._lib.strings.split.partition import partition, rpartition
from cudf._lib.strings.split.split import (
rsplit,
Expand All @@ -99,7 +47,3 @@
split_record,
split_record_re,
)
from cudf._lib.strings.strip import lstrip, rstrip, strip
from cudf._lib.strings.substring import get, slice_from, slice_strings
from cudf._lib.strings.translate import filter_characters, translate
from cudf._lib.strings.wrap import wrap
43 changes: 0 additions & 43 deletions python/cudf/cudf/_lib/strings/attributes.pyx

This file was deleted.

34 changes: 0 additions & 34 deletions python/cudf/cudf/_lib/strings/capitalize.pyx

This file was deleted.

34 changes: 0 additions & 34 deletions python/cudf/cudf/_lib/strings/case.pyx

This file was deleted.

141 changes: 0 additions & 141 deletions python/cudf/cudf/_lib/strings/char_types.pyx

This file was deleted.

Loading
Loading