Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xxhash_64 to utilize the cuco equivalent implementation #17393

Merged
merged 9 commits into from
Nov 22, 2024

Conversation

PointKernel
Copy link
Member

@PointKernel PointKernel commented Nov 21, 2024

Description

This PR updates xxhash_64 to leverage the cuco equivalent implementation and makes it available as a cudf detail utility, as requested by @mhaseeb123. Additionally, it fixes a minor issue in the murmurhash3_x64_128.cuh header by adding the missing #pragma once directive.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@PointKernel PointKernel added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 21, 2024
Copy link
Member

@mhaseeb123 mhaseeb123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quickly adding these changes.

@mhaseeb123 mhaseeb123 added the cuco cuCollections related issue label Nov 22, 2024
@PointKernel
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 092fdff into rapidsai:branch-25.02 Nov 22, 2024
104 checks passed
@PointKernel PointKernel deleted the cleanup-xxhash64 branch November 22, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team cuco cuCollections related issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants