Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cudf._lib.transpose in favor of inlining pylibcudf #17365

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Remove cudf._lib.transpose in favor of inlining pylibcudf #17365

merged 5 commits into from
Nov 22, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Contributes to #17317

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 19, 2024
@mroeschke mroeschke requested a review from a team as a code owner November 19, 2024 18:53
@mroeschke mroeschke requested review from bdice and Matt711 November 19, 2024 18:53
@github-actions github-actions bot added the CMake CMake build issue label Nov 19, 2024
Matt711
Matt711 approved these changes Nov 19, 2024
View reviewed changes
python/cudf/cudf/core/dataframe.py Outdated Show resolved Hide resolved
@mroeschke mroeschke force-pushed the cudf/_libs/transpose branch from 8b01833 to 2abc5f4 Compare November 20, 2024 01:16
@mroeschke mroeschke requested review from a team as code owners November 20, 2024 01:16
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. Java Affects Java cuDF API. cudf.pandas Issues specific to cudf.pandas cudf.polars Issues specific to cudf.polars pylibcudf Issues specific to the pylibcudf package labels Nov 20, 2024
@mroeschke mroeschke changed the base branch from branch-24.12 to branch-25.02 November 20, 2024 01:16
@github-actions github-actions bot removed libcudf Affects libcudf (C++/CUDA) code. Java Affects Java cuDF API. cudf.pandas Issues specific to cudf.pandas cudf.polars Issues specific to cudf.polars pylibcudf Issues specific to the pylibcudf package labels Nov 20, 2024
KyleFromNVIDIA
KyleFromNVIDIA approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved trivial CMake changes

@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 881afd1 into rapidsai:branch-25.02 Nov 22, 2024
104 checks passed
@mroeschke mroeschke deleted the cudf/_libs/transpose branch November 22, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleFromNVIDIA KyleFromNVIDIA KyleFromNVIDIA approved these changes

@Matt711 Matt711 Matt711 approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@mroeschke mroeschke

Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mroeschke @Matt711 @KyleFromNVIDIA