Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document interpreter install command for cudf.pandas #17358

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Document interpreter install command for cudf.pandas #17358

merged 3 commits into from
Nov 21, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Nov 18, 2024

Description

This PR adds documentation for cudf.pandas.install() alongside the usage instructions for %load_ext cudf.pandas and -m cudf.pandas methods.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice changed the base branch from branch-24.12 to branch-25.02 November 18, 2024 21:53
@bdice bdice marked this pull request as ready for review November 18, 2024 21:54
@bdice bdice requested a review from galipremsagar November 18, 2024 22:23
vyasr
vyasr approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small suggestions for improvement but nothing blocking. Feel free to ignore them if you don't like them.

docs/cudf/source/cudf_pandas/usage.md Outdated Show resolved Hide resolved
docs/cudf/source/cudf_pandas/usage.md Outdated Show resolved Hide resolved
docs/cudf/source/cudf_pandas/usage.md Outdated Show resolved Hide resolved
@bdice
Copy link
Contributor Author

bdice commented Nov 20, 2024

I'm going to let the CI run and look at the docs before merging, but I think it should be good to go now. I added a bit of summary at the top and applied the suggestions from @vyasr.

@bdice bdice added doc Documentation non-breaking Non-breaking change labels Nov 20, 2024
@bdice
Copy link
Contributor Author

bdice commented Nov 21, 2024

/merge

@rapids-bot rapids-bot bot merged commit b2419dd into rapidsai:branch-25.02 Nov 21, 2024
88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@galipremsagar galipremsagar Awaiting requested review from galipremsagar

Assignees

@bdice bdice

Labels
doc Documentation non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdice @vyasr