Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add comment to Series.tolist method #17350

Merged
merged 5 commits into from
Dec 3, 2024
Merged

add comment to Series.tolist method #17350

merged 5 commits into from
Dec 3, 2024

Conversation

tequilayu
Copy link
Contributor

@tequilayu tequilayu commented Nov 17, 2024 •
edited by isVoid
Loading

Description

closes #15767

This PR adds comment to Series.tolist method. It mentions that the method will raise a TypeError when it's called and suggest alternatives.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@tequilayu tequilayu requested a review from a team as a code owner November 17, 2024 04:23
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 17, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the Python Affects Python cuDF API. label Nov 17, 2024
mroeschke
mroeschke requested changes Nov 18, 2024
View reviewed changes
python/cudf/cudf/core/series.py Outdated Show resolved Hide resolved
@mroeschke mroeschke added the doc Documentation label Nov 18, 2024
@isVoid isVoid added the non-breaking Non-breaking change label Nov 21, 2024
@isVoid isVoid requested a review from mroeschke November 21, 2024 06:37
@vyasr
Copy link
Contributor

vyasr commented Dec 2, 2024

/ok to test

@vyasr
Copy link
Contributor

vyasr commented Dec 2, 2024

/merge

@vyasr
Copy link
Contributor

vyasr commented Dec 2, 2024

/ok to test

@rapids-bot rapids-bot bot merged commit 12c77f3 into rapidsai:branch-25.02 Dec 3, 2024
105 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@vyasr vyasr

@isVoid isVoid

@tequilayu tequilayu

Labels
doc Documentation non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC] cudf.Series.to_list is empty
4 participants
@tequilayu @vyasr @mroeschke @isVoid