Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move make_strings_column benchmark to nvbench #17340

Merged
merged 10 commits into from
Dec 2, 2024
Merged

Move make_strings_column benchmark to nvbench #17340

merged 10 commits into from
Dec 2, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Moves the cpp/benchmarks/string/factory.cu implementation from google-bench to nvbench.
Also renames to .cpp by recoding without device code.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 15, 2024
@davidwendt davidwendt self-assigned this Nov 15, 2024
@github-actions github-actions bot added the CMake CMake build issue label Nov 15, 2024
@davidwendt davidwendt changed the base branch from branch-24.12 to branch-25.02 November 21, 2024 16:08
@davidwendt davidwendt marked this pull request as ready for review November 22, 2024 13:26
@davidwendt davidwendt requested a review from a team as a code owner November 22, 2024 13:26
@vyasr
Copy link
Contributor

vyasr commented Dec 2, 2024

/merge

@rapids-bot rapids-bot bot merged commit 3e418dd into rapidsai:branch-25.02 Dec 2, 2024
104 checks passed
@davidwendt davidwendt deleted the strings-factory-nvbench branch December 2, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@vyasr vyasr vyasr approved these changes

@kingcrimsontianyu kingcrimsontianyu Awaiting requested review from kingcrimsontianyu kingcrimsontianyu is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec nvdbaranec is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @vyasr @bdice