Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract GPUEngine config options at translation time #17339

Merged
merged 9 commits into from
Nov 20, 2024
Merged

Extract GPUEngine config options at translation time #17339

merged 9 commits into from
Nov 20, 2024

Conversation

rjzamora
Copy link
Member

Description

Follow up to #16944
That PR added config: GPUEngine to the arguments of every IR.do_evaluate function. In order to simplify future multi-GPU development, this PR extracts the necessary configuration argument at IR translation time instead.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@rjzamora rjzamora added 2 - In Progress Currently a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 15, 2024
@github-actions github-actions bot added Python Affects Python cuDF API. cudf.polars Issues specific to cudf.polars labels Nov 15, 2024
@rjzamora rjzamora mentioned this pull request Nov 15, 2024
Merged
@rjzamora rjzamora marked this pull request as ready for review November 15, 2024 18:36
@rjzamora rjzamora requested a review from a team as a code owner November 15, 2024 18:36
@rjzamora rjzamora added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Nov 15, 2024
brandon-b-miller
brandon-b-miller approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@brandon-b-miller brandon-b-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm +1 here.

@rjzamora
Copy link
Member Author

@wence- - I think this is ready for a final review. Let me know if we are still good to target 24.12.

@rjzamora rjzamora added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Nov 20, 2024
@vyasr
Copy link
Contributor

vyasr commented Nov 20, 2024 •
edited
Loading

The error code in the polars tests here is the same that we observed in a few runs on #17362 such as this one. @wence- have you seen that anywhere else? Is it something that we need to do any debugging of? It looks like this branch is up-to-date with the latest 24.12 so there's no relevant upstream fix yet, but this could be some runner issue or something else unrelated to cudf-polars.

@rjzamora
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit f550ccc into rapidsai:branch-24.12 Nov 20, 2024
104 checks passed
@rjzamora rjzamora deleted the move-config branch November 20, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- approved these changes

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@wence- wence-

@rjzamora rjzamora

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge cudf.polars Issues specific to cudf.polars improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rjzamora @vyasr @wence- @brandon-b-miller