Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix library-loading issues in editable installs #17338

Merged
merged 3 commits into from
Nov 19, 2024
Merged

fix library-loading issues in editable installs #17338

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a44920
fix library-loading issues in editable installs
jameslamb Nov 15, 2024
5493fc0
devcontainer builds are done on CPU nodes, skip smoke tests
jameslamb Nov 15, 2024
7a36954
Merge branch 'branch-24.12' into fix-library-loading
Matt711 Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions python/libcudf/libcudf/load.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,15 @@ def load_library():
# Prefer the libraries bundled in this package. If they aren't found
# (which might be the case in builds where the library was prebuilt before
# packaging the wheel), look for a system installation.
libcudf_lib = _load_wheel_installation(soname)
if libcudf_lib is None:
libcudf_lib = _load_system_installation(soname)
try:
libcudf_lib = _load_wheel_installation(soname)
if libcudf_lib is None:
libcudf_lib = _load_system_installation(soname)
except OSError:
# If none of the searches above succeed, just silently return None
# and rely on other mechanisms (like RPATHs on other DSOs) to
# help the loader find the library.
pass

# The caller almost never needs to do anything with this library, but no
# harm in offering the option since this object at least provides a handle
Expand Down
Loading