Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the full matrix for polars and dask wheels on nightlies #17320

Merged
merged 8 commits into from
Nov 18, 2024

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Nov 14, 2024

Description

This PR ensures that we have nightly coverage of more of the CUDA/Python/arch versions that we claim to support for dask-cudf and cudf-polars wheels.

In addition, this PR ensures that we do not attempt to run the dbgen executable in the Polars repository on systems with too old of a glibc to support running them.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 14, 2024
@vyasr vyasr self-assigned this Nov 14, 2024
@vyasr vyasr marked this pull request as ready for review November 15, 2024 22:09
@vyasr vyasr requested a review from a team as a code owner November 15, 2024 22:09
@vyasr vyasr requested a review from bdice November 15, 2024 22:09
@vyasr
Copy link
Contributor Author

vyasr commented Nov 15, 2024

To validate that the new matrix entries will run successfully I modified pr.yaml to run the tests in PR CI once as well. See the CI run in cb21548 for that verification.

For more information on the glibc change, see #17336.

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question but all looks fine to me.

DESELECTED_TESTS+=("tests/benchmark/test_pdsh.py::test_pdsh")
# The connectorx package is not available on arm
DESELECTED_TESTS+=("tests/unit/io/database/test_read.py::test_read_database")
# The necessary timezone information cannot be found in our CI image.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What timezone info are we missing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vyasr
Copy link
Contributor Author

vyasr commented Nov 18, 2024

/merge

@rapids-bot rapids-bot bot merged commit d514517 into rapidsai:branch-24.12 Nov 18, 2024
107 checks passed
@vyasr vyasr deleted the feat/expand_testing_matrix branch November 18, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants