Exclude nanoarrow and flatbuffers from installation #17308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
improvement
|
CC @jameslamb |
github-actions
bot
added
libcudf
harrism
approved these changes
Nov 13, 2024
bdice
approved these changes
Nov 13, 2024
|
For the record, I spot-checked the wheels, one each for libcudf/pylibcudf/cudf: (main) dt08% unzip -l cudf_cu11-24.12.0a344-cp310-cp310-manylinux_2_24_aarch64.manylinux_2_28_aarch64.whl | grep "flatbuffers"
(main) dt08% unzip -l cudf_cu11-24.12.0a344-cp310-cp310-manylinux_2_24_aarch64.manylinux_2_28_aarch64.whl | grep "nanoarrow"
(main) dt08% unzip -l pylibcudf_cu12-24.12.0a344-cp311-cp311-manylinux_2_24_aarch64.manylinux_2_28_aarch64.whl| grep "flatbuffers"
(main) dt08% unzip -l pylibcudf_cu12-24.12.0a344-cp311-cp311-manylinux_2_24_aarch64.manylinux_2_28_aarch64.whl| grep "nanoarrow"
(main) dt08% unzip -l libcudf_cu12-24.12.0a344-py3-none-manylinux_2_28_x86_64.whl | grep "flatbuffer"
(main) dt08% unzip -l libcudf_cu12-24.12.0a344-py3-none-manylinux_2_28_x86_64.whl | grep "nanoarrow"
|
|
/merge |
|
Oh awesome, glad this was really all it took. Thank you! |
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 15, 2024
…lly linked (#17322) Had an issue crop up in spark-rapids-jni where we statically link arrow and the build started to fail due to change #17308. Authors: - Mike Wilson (https://github.com/hyperbolic2346) Approvers: - Gera Shegalov (https://github.com/gerashegalov) - Vyas Ramasubramani (https://github.com/vyasr) - Bradley Dice (https://github.com/bdice) - Kyle Edwards (https://github.com/KyleFromNVIDIA) URL: #17322
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change helps shrink RAPIDS wheels. It should not affect Spark builds since those use the build directory of cudf and statically link in those components to its final binary.
Checklist