Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Occupancy improvement for distinct hash join with specialized dispatch #17290

Open
wants to merge 3 commits into
base: branch-24.12
Choose a base branch
from
Open

Occupancy improvement for distinct hash join with specialized dispatch #17290

wants to merge 3 commits into from

Conversation

tgujar
Copy link
Contributor

@tgujar tgujar commented Nov 9, 2024

Description

MR adds specialized dispatch for distinct hash join insert and probe operations to avoid high occupancy cost of complex data types.
This is a split of the original MR #15700 so that its easier to review and merge. It contains all the changes from previous comments on relevant files.
Addresses #15502 for distinct hash joins

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@tgujar tgujar requested a review from a team as a code owner November 9, 2024 03:05
@tgujar tgujar requested review from harrism and shrshi November 9, 2024 03:05
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 9, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Nov 9, 2024
@PointKernel PointKernel self-requested a review November 9, 2024 03:08
@PointKernel PointKernel added breaking Breaking change improvement Improvement / enhancement to an existing function Performance Performance related issue 3 - Ready for Review Ready for review by team labels Nov 10, 2024
@PointKernel
Copy link
Member

/ok to test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- left review comments

@harrism harrism Awaiting requested review from harrism harrism is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@shrshi shrshi Awaiting requested review from shrshi shrshi is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@PointKernel PointKernel Awaiting requested review from PointKernel

Assignees

@PointKernel PointKernel

@tgujar tgujar

Labels
3 - Ready for Review Ready for review by team breaking Breaking change improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. Performance Performance related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tgujar @PointKernel @wence-