Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pylibcudf enums in cudf Python quantile #17287

Merged
merged 2 commits into from
Nov 9, 2024
Merged

Use pylibcudf enums in cudf Python quantile #17287

merged 2 commits into from
Nov 9, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Shouldn't need to use the "private" pylibcudf.libcudf types anymore now that the Python side enums are exposed

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 8, 2024
@mroeschke mroeschke requested a review from a team as a code owner November 8, 2024 21:33
@mroeschke mroeschke mentioned this pull request Nov 8, 2024
Merged
3 tasks
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit e399e95 into rapidsai:branch-24.12 Nov 9, 2024
102 checks passed
@mroeschke mroeschke deleted the plc/cln/quantile branch November 9, 2024 01:19
rapids-bot bot pushed a commit that referenced this pull request Nov 9, 2024
@mroeschke
Use more pylibcudf Python enums in cudf._lib (#17288)
7a499f6 
Similar to #17287. Also remove a `plc` naming shadowing

Authors:
  - Matthew Roeschke (https://github.com/mroeschke)

Approvers:
  - Matthew Murray (https://github.com/Matt711)

URL: #17288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matt711 Matt711 Matt711 approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@mroeschke mroeschke

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @Matt711