-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enforce wheel size limits, README formatting in CI #17284
enforce wheel size limits, README formatting in CI #17284
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be implemented in https://github.com/rapidsai/gha-tools?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline -- maybe we can centralize this in the future. There may be some differences in how paths / current directories are handled across repositories. For now this is not a priority.
/merge |
Description
Contributes to rapidsai/build-planning#110
Proposes adding 2 types of validation on wheels in CI, to ensure we continue to produce wheels that are suitable for PyPI.
Notes for Reviewers
How I tested this
Initially set the size threshold for
libcudf
to a value that I knew it'd violate (75MB compressed, when the wheels are 400+ MB compressed).Saw CI fail as expected, and print a summary with the expected contents.
(build link)
Updated that threshold in
python/libcudf/pyproject.toml
, and saw the build succeed (but the summary still printed).Checklist