Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add catboost to the third-party integration tests #17267

Merged
merged 10 commits into from
Nov 13, 2024
Merged

Add catboost to the third-party integration tests #17267

merged 10 commits into from
Nov 13, 2024

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Nov 7, 2024

Description

Closes #15397

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added Python Affects Python cuDF API. cudf.pandas Issues specific to cudf.pandas labels Nov 7, 2024
@Matt711 Matt711 added feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API. cudf.pandas Issues specific to cudf.pandas and removed Python Affects Python cuDF API. cudf.pandas Issues specific to cudf.pandas labels Nov 7, 2024
Matt711
Matt711 commented Nov 8, 2024
View reviewed changes
.github/workflows/pr.yaml Outdated
@@ -37,6 +37,7 @@ jobs:
- unit-tests-cudf-pandas
- pandas-tests
- pandas-tests-diff
- third-party-integration-tests-cudf-pandas
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore the CI changes. I added them to show the third-party integration tests were passing. I'll delete them once this PR is approved.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the ping

@Matt711 Matt711 marked this pull request as ready for review November 8, 2024 21:25
@Matt711 Matt711 requested review from a team as code owners November 8, 2024 21:25
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 13, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@Matt711
Copy link
Contributor Author

Matt711 commented Nov 13, 2024

/ok to test

@Matt711
Copy link
Contributor Author

Matt711 commented Nov 13, 2024

/merge

@vyasr
Copy link
Contributor

vyasr commented Nov 13, 2024

/ok to test

@rapids-bot rapids-bot bot merged commit 1b045dd into rapidsai:branch-24.12 Nov 13, 2024
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@mroeschke mroeschke mroeschke approved these changes

@KyleFromNVIDIA KyleFromNVIDIA Awaiting requested review from KyleFromNVIDIA KyleFromNVIDIA was automatically assigned from rapidsai/ci-codeowners

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@vyasr vyasr Awaiting requested review from vyasr

Assignees

@Matt711 Matt711

Labels
cudf.pandas Issues specific to cudf.pandas feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Improve support or failure modes for numpy and other libraries with C APIs in cudf.pandas
5 participants
@Matt711 @vyasr @bdice @mroeschke @galipremsagar