Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always prefer device_reads and device_writes when kvikIO is enabled #17260

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Always prefer device_reads and device_writes when kvikIO is enabled #17260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
62eed59
remove threshold for kvikIO
vuule Nov 6, 2024
76f1f62
Merge branch 'branch-24.12' into impr-prefer-kvikio-device-read
vuule Nov 7, 2024
af04bba
Merge branch 'branch-24.12' of https://github.com/rapidsai/cudf into …
vuule Nov 12, 2024
c9e7c76
data_sink side
vuule Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions cpp/src/io/utilities/data_sink.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,12 @@ class file_sink : public data_sink {

[[nodiscard]] bool is_device_write_preferred(size_t size) const override
{
if (size < _gds_write_preferred_threshold) { return false; }
return supports_device_write();
if (!supports_device_write()) { return false; }

// Always prefer device writes if kvikio is enabled
if (!_kvikio_file.closed()) { return true; }

return size >= _gds_write_preferred_threshold;
}

std::future<void> device_write_async(void const* gpu_data,
Expand Down
8 changes: 6 additions & 2 deletions cpp/src/io/utilities/datasource.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,12 @@ class file_source : public datasource {

[[nodiscard]] bool is_device_read_preferred(size_t size) const override
{
if (size < _gds_read_preferred_threshold) { return false; }
return supports_device_read();
if (!supports_device_read()) { return false; }

// Always prefer device reads if kvikio is enabled
if (!_kvikio_file.closed()) { return true; }

return size >= _gds_read_preferred_threshold;
}

std::future<size_t> device_read_async(size_t offset,
Expand Down
Loading