Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extract-datetime deprecation warning in ndsh benchmark #17254

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Fixes deprecation warning introduced by #17221

[165+3+59=226] Building CXX object benchmarks/CMakeFiles/NDSH_Q09_NVBENCH.dir/ndsh/q09.cpp.o
/cudf/cpp/benchmarks/ndsh/q09.cpp: In function 'void run_ndsh_q9(nvbench::state&, std::unordered_map<std::__cxx11::basic_string<char>, cuio_source_sink_pair>&)':
/cudf/cpp/benchmarks/ndsh/q09.cpp:148:33: warning: 'std::unique_ptr<cudf::column> cudf::datetime::extract_year(const cudf::column_view&, rmm::cuda_stream_view, rmm::device_async_resource_ref)' is deprecated [-Wdeprecated-declarations]
  148 |   auto o_year = cudf::datetime::extract_year(joined_table->column("o_orderdate"));
      |                                 ^~~~~~~~~~~~
In file included from /cudf/cpp/benchmarks/ndsh/q09.cpp:21:
/cudf/cpp/include/cudf/datetime.hpp:70:46: note: declared here
   70 | [[deprecated]] std::unique_ptr<cudf::column> extract_year(
      |                                              ^~~~~~~~~~~~
/cudf/cpp/benchmarks/ndsh/q09.cpp:148:45: warning: 'std::unique_ptr<cudf::column> cudf::datetime::extract_year(const cudf::column_view&, rmm::cuda_stream_view, rmm::device_async_resource_ref)' is deprecated [-Wdeprecated-declarations]
  148 |   auto o_year = cudf::datetime::extract_year(joined_table->column("o_orderdate"));
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /cudf/cpp/benchmarks/ndsh/q09.cpp:21:
/cudf/cpp/include/cudf/datetime.hpp:70:46: note: declared here
   70 | [[deprecated]] std::unique_ptr<cudf::column> extract_year(
      |                                              ^~~~~~~~~~~~

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Nov 6, 2024
@davidwendt davidwendt self-assigned this Nov 6, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Nov 6, 2024
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this.

@davidwendt davidwendt marked this pull request as ready for review November 7, 2024 11:15
@davidwendt davidwendt requested a review from a team as a code owner November 7, 2024 11:15
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 1981445 into rapidsai:branch-24.12 Nov 7, 2024
102 checks passed
@davidwendt davidwendt deleted the dep-warn-ndsh branch November 7, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants