-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new dask_cudf.read_parquet
API
#17250
Merged
rapids-bot
merged 28 commits into
rapidsai:branch-24.12
from
rjzamora:new-read-parquet-api
Nov 20, 2024
Merged
Changes from 17 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
3e853f8
add new read_parquet API to dask_cudf
rjzamora b30c529
fix non-expr deprecation
rjzamora e3c640a
fix CudfReadParquetFSSpec fusion
rjzamora e482026
correct for aggregate_files=False
rjzamora b9af7b7
Merge remote-tracking branch 'upstream/branch-24.12' into new-read-pa…
rjzamora 2ad1867
update default blocksize, and add docstring
rjzamora 6c37a9c
Merge branch 'branch-24.12' into new-read-parquet-api
rjzamora 53dfbdf
Merge branch 'branch-24.12' into new-read-parquet-api
rjzamora 900ebf6
Merge remote-tracking branch 'upstream/branch-24.12' into new-read-pa…
rjzamora 3fb23fd
revise _normalize_blocksize
rjzamora 7af233e
Merge remote-tracking branch 'upstream/branch-24.12' into new-read-pa…
rjzamora 0552b33
fix test
rjzamora 564c13c
proper test fix - and disable dataset processing unless necessary
rjzamora 64dd105
preserve default hive handling in cudf
rjzamora 68b8faf
Merge remote-tracking branch 'upstream/branch-24.12' into new-read-pa…
rjzamora e074004
Merge branch 'branch-24.12' into new-read-parquet-api
rjzamora a305398
Merge branch 'branch-24.12' into new-read-parquet-api
vyasr b539ed4
Merge remote-tracking branch 'upstream/branch-24.12' into new-read-pa…
rjzamora 0291b95
address code review
rjzamora beafffb
Merge remote-tracking branch 'upstream/branch-24.12' into new-read-pa…
rjzamora 0832e55
sample single worker for device size
rjzamora db82e0b
Merge remote-tracking branch 'upstream/branch-24.12' into new-read-pa…
rjzamora df1e283
Merge branch 'branch-24.12' into new-read-parquet-api
rjzamora 2195947
use CUDA_VISIBLE_DEVICES
rjzamora 1038170
Merge branch 'new-read-parquet-api' of github.com:rjzamora/cudf into …
rjzamora 0ecf6dd
support mig
rjzamora fa03396
Update python/dask_cudf/dask_cudf/io/parquet.py
rjzamora 1b79270
Merge branch 'branch-24.12' into new-read-parquet-api
madsbk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
pyarrow.dataset
logic below has non-negligible overhead on remove storage. This code block allows us to pass indataset_kwargs={"partitioning": None}
to skip unnecessary PyArrow processing when we know we are not reading from hive-partitioned data (and we aren't applying filters).By default (when we don't pass in
dataset_kwargs={"partitioning": None}
), cudf will still pre-process the dataset with PyArrow just in case it is hive partitioned.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the context @rjzamora ! Do you happen to have the rough overhead numbers/magnitude?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overhead is measurable but not huge (~4-5%) for the specific case I was benchmarking.