Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add breaking change workflow trigger #17248

Merged

Conversation

AyodeAwe
Copy link
Contributor

@AyodeAwe AyodeAwe commented Nov 5, 2024

Adds a workflow that triggers a second workflow which sends a notification to a designated Slack channel on every PR labelled with breaking, whenever any of the following events are triggered on the PR:

  • closed
  • reopened
  • labeled
  • unlabeled

Depends on rapidsai/shared-workflows#257

@AyodeAwe AyodeAwe requested a review from a team as a code owner November 5, 2024 18:37
@AyodeAwe AyodeAwe requested a review from jameslamb November 5, 2024 18:37
@AyodeAwe AyodeAwe added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Nov 5, 2024
@davidwendt
Copy link
Contributor

I thought we already had this.
There is an existing slack channel that gets messages for breaking labelled PRs in cudf.

@AyodeAwe
Copy link
Contributor Author

AyodeAwe commented Nov 5, 2024

I thought we already had this. There is an existing slack channel that gets messages for breaking labelled PRs in cudf.

The implementation you're referring to exists in our old Jenkins CI which we're trying to decomission. With this PR we're essentially migrating the implementation to GHA.

@AyodeAwe AyodeAwe marked this pull request as draft November 5, 2024 20:48
@AyodeAwe AyodeAwe force-pushed the add-breaking-change-notifier branch from 20b8a87 to 458199d Compare November 6, 2024 13:24
@AyodeAwe AyodeAwe force-pushed the add-breaking-change-notifier branch from 458199d to 7e9ef31 Compare November 7, 2024 19:24
@AyodeAwe AyodeAwe marked this pull request as ready for review November 14, 2024 15:29
@AyodeAwe AyodeAwe changed the base branch from branch-24.12 to branch-25.02 November 20, 2024 21:10
@AyodeAwe AyodeAwe merged commit fa62ff4 into rapidsai:branch-25.02 Nov 26, 2024
105 of 107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants