Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for kvikio with lowercase #17243

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Nov 4, 2024

Description

The case-sensitive name KvikIO is will throw off find_package searches, particularly after rapidsai/devcontainers#414 make the usage consistent in devcontainers.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 4, 2024
@vyasr vyasr self-assigned this Nov 4, 2024
@vyasr vyasr requested a review from a team as a code owner November 4, 2024 22:06
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Nov 4, 2024
@madsbk madsbk mentioned this pull request Nov 6, 2024
2 tasks
@AyodeAwe AyodeAwe merged commit adf3269 into rapidsai:branch-24.12 Nov 6, 2024
95 of 117 checks passed
@vyasr vyasr deleted the fix/kvikio_casing branch November 6, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants